Skip to content

Extend _tensor_elementwise_impl with binary functions part 2#2804

Merged
vlad-perevezentsev merged 205 commits into
include-dpctl-tensorfrom
move_elementwise_binary_impl_part_2
Mar 18, 2026
Merged

Extend _tensor_elementwise_impl with binary functions part 2#2804
vlad-perevezentsev merged 205 commits into
include-dpctl-tensorfrom
move_elementwise_binary_impl_part_2

Conversation

@vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR extends _tensor_elementwise_impl with part of binary functions : divide, equal, floor_divide, greater, greater_equal, hypot, less, less_equal, logaddexp

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev
Rename folder dpctl to dpctl_ext
d4fd805
@vlad-perevezentsev
Add simplify_iteration_space implementation to libtensor
c040713
@vlad-perevezentsev
Extend codespell ignore list for libtensor
14b466f
@vlad-perevezentsev
Add copy_and_cast kernels to libtensor
dcc421b
@vlad-perevezentsev
Add copy_usm_ndarray_into_usm_ndarray implementation
5a9c14c
@vlad-perevezentsev
Add pybind11 bindings for dpctl_ext.tensor._tensor_impl
4f63340
@vlad-perevezentsev
Add CMake build files for dpctl_ext
634579c
@vlad-perevezentsev
Add empty __init__ to dpctl_ext/
79d40f2
@vlad-perevezentsev
Enable _same_logical_tensors in _tensor_impl
7949c17
@vlad-perevezentsev
Add device_support_queries to enable default device types
29d6c02
@vlad-perevezentsev
Enable building and packaging of dpctl_ext
936e719
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext.tensor in dpnp
cd85f1e
@vlad-perevezentsev
Move put() and take() to dpctl_ext/tensor
0c6780a
@vlad-perevezentsev
Use put/take from dpctl_ext.tensor in dpnp
87e5482
@vlad-perevezentsev
Move full() to dpctl_ext/tensor
b537f30
@vlad-perevezentsev
Use full and _full_usm_ndarray from dpctl_ext in dpnp
d50f263
@vlad-perevezentsev
Update .gitignore to ignore .so files in dpctl_ext
f189dc5
@vlad-perevezentsev
Move _zeros_usm_ndarray to dpctl_ext
f9a1817
@vlad-perevezentsev
Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py
4b8505a
@vlad-perevezentsev
Move linear-sequence implementations to dpctl_ext/tensor
61106b2
@vlad-perevezentsev
Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py
a030579
@vlad-perevezentsev
Move tril()/triu() to dpctl_ext/tensor
a1d6fa3
@vlad-perevezentsev
Use tril/triu/_tril from dpctl_ext.tensor in dpnp
f1d6e56
@vlad-perevezentsev
Disable pylint no-name-in-module for dpctl_ext
6680790
@vlad-perevezentsev
Add TODO comments
263b717
@vlad-perevezentsev
Use default_device_complex_type from dpctl_ext on test_array_api_info.py
4130c1b
@vlad-perevezentsev
Remove unused build_dpctl_ext function
17ca9ab
@vlad-perevezentsev
Apply remarks for CMake files
79cb2a4
@vlad-perevezentsev
Apply remarks for c++ files
4bf080e
@vlad-perevezentsev
Remove linear-sequence implementations
cfa6cd6
ndgrigorian and others added 13 commits March 5, 2026 16:35
@vlad-perevezentsev
vlad-perevezentsev marked this pull request as ready for review March 11, 2026 15:56
@vlad-perevezentsev
vlad-perevezentsev force-pushed the move_elementwise_binary_impl_part_2 branch from a3b2d00 to 608802a Compare March 11, 2026 18:53
ndgrigorian
ndgrigorian previously approved these changes Mar 12, 2026
View reviewed changes

@ndgrigorian ndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over includes and nothing stood out, this one LGTM

@ndgrigorian
ndgrigorian self-requested a review March 12, 2026 01:11
@ndgrigorian
ndgrigorian dismissed their stale review March 12, 2026 01:11

was put in wrong PR

Base automatically changed from move_elementwise_binary_impl to include-dpctl-tensor March 18, 2026 14:23
antonwolfy
antonwolfy reviewed Mar 18, 2026
View reviewed changes
Comment thread dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp
Comment thread dpctl_ext/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Comment thread dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/equal.hpp Outdated
Comment thread dpctl_ext/tensor/libtensor/source/elementwise_functions/elementwise_common.cpp
@github-actions

github-actions Bot commented Mar 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_228 ran successfully.
Passed: 1355
Failed: 2
Skipped: 16

antonwolfy
antonwolfy approved these changes Mar 18, 2026
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlad-perevezentsev
vlad-perevezentsev merged commit 1bfa011 into include-dpctl-tensor Mar 18, 2026
15 of 26 checks passed
@vlad-perevezentsev
vlad-perevezentsev deleted the move_elementwise_binary_impl_part_2 branch March 18, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @ndgrigorian @antonwolfy